Only use kMaxIfNameLength instead of IFNAMSIZ #37859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I encountered IFNAMSIZ is not defined when doing some porting. I think it's better to use the unified definition for network interface name in this project.
andy31415
approved these changes
Mar 4, 2025
|
PR #37859: Size comparison from 13da787 to b4d6ddd Full report (74 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37859: Size comparison from c31efb2 to f8c3c9b Full report (74 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
| @@ -154,7 +154,7 @@ void LogDetails(InetInterfacesVector inetInterfaces, Inet6InterfacesVector inet6 | |||
|
|
|||
| for (auto interfaceId : interfaceIds) | |||
| { | |||
| char interfaceName[IFNAMSIZ] = {}; | |||
| char interfaceName[chip::Inet::InterfaceId::kMaxIfNameLength] = {}; | |||
There was a problem hiding this comment.
Please remove the redundant chip:: prefixes a least in the Darwin code, if not throughout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered
IFNAMSIZis not defined when doing some porting. I think it's better to use the unified definition for network interface name in this project.Testing
This is a trivial change and should be covered by the CI build tests.